components/autofill/core/browser/webdata/autofill_webdata_backend.h - Issue 2142123002: [Autofill] Run autofill-profile de-dupe after sync starts if sync is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_webdata_backend.h

Issue 2142123002: [Autofill] Run autofill-profile de-dupe after sync starts if sync is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Perform at most a single merge for new incoming sync data Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/personal_data_manager.cc ('K') | « components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc ('k') | components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h » ('j') | components/autofill/core/browser/webdata/autofill_webdata_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_webdata_backend.h

diff --git a/components/autofill/core/browser/webdata/autofill_webdata_backend.h b/components/autofill/core/browser/webdata/autofill_webdata_backend.h

index 8b06ffb926f53b07cac0ccb8307c976abdd9494f..3f138ba1f2925083bee26c2ba8a7bd402a1db18f 100644

--- a/components/autofill/core/browser/webdata/autofill_webdata_backend.h

+++ b/components/autofill/core/browser/webdata/autofill_webdata_backend.h

@@ -5,6 +5,8 @@

#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOFILL_WEBDATA_BACKEND_H_

#define COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOFILL_WEBDATA_BACKEND_H_

+#include "sync/internal_api/public/base/model_type.h"

class WebDatabase;

namespace autofill {

@@ -36,6 +38,10 @@ class AutofillWebDataBackend {

// NOTE: This method is intended to be called from the DB thread. The UI

// thread notifications are asynchronous.

virtual void NotifyOfMultipleAutofillChanges() = 0;

+ // Notifies listeners on both DB and UI threads that sync has started for

Mathieu 2016/07/18 14:53:19 Not sure I see how DB thread observers are notifie

Roger McFarlane (Chromium) 2016/07/18 15:29:18 Copy-paste error, fixed.

+ // |model_type|.

+ virtual void NotifyThatSyncHasStarted(syncer::ModelType model_type) = 0;

};

} // namespace autofill