[Autofill] Run autofill-profile de-dupe after sync starts if sync is enabled.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 197 matching lines @@
       user_did_autofill_(false),
       user_did_edit_autofilled_field_(false),
       user_did_accept_upload_prompt_(false),
       external_delegate_(NULL),
       test_delegate_(NULL),
       weak_ptr_factory_(this) {
   if (enable_download_manager == ENABLE_AUTOFILL_DOWNLOAD_MANAGER) {
     download_manager_.reset(new AutofillDownloadManager(driver, this));
   }
   CountryNames::SetLocaleString(app_locale_);
+  if (personal_data_ && client_)
+    personal_data_->OnSyncServiceConfigured(client_->GetSyncService());

[Nicolas Zea, 2016/07/12 20:04:47]

How do you know that the sync service is configured at this point in time? Kind
of seems like a strange place to make this call, but I'm not too familiar with
the autofill initialization process.

[Roger McFarlane (Chromium), 2016/07/12 21:23:26]

Because we're in the context of the AutofillManager, which is given a bunch of
existing and otherwise usable things to manage.

OnSyncServiceConfigured might be an overly strong name. Perhaps it would be
better named "OnValidSyncServicePointerAvailable()"

:)

All I really need at this point is a valid SyncService instance that I can query
about whether it will eventually be doing autofill profile syncing.

 }
 
 AutofillManager::~AutofillManager() {}
 
 // static
 void AutofillManager::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(
       prefs::kAutofillEnabled,
       true,
@@ skipping 1798 matching lines @@
     if (i > 0)
       fputs("Next oldest form:\n", file);
   }
   fputs("\n", file);
 
   fclose(file);
 }
 #endif  // ENABLE_FORM_DEBUG_DUMP
 
 }  // namespace autofill