Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142103002: Remove exclamation mark from bookmark bubble title (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, ainslie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove exclamation mark from bookmark bubble title "Bookmark added!" => "Bookmark added" ainslie@ says it doesn't belong. BUG=none Committed: https://crrev.com/21ab243152fed3cb57fadc8ccf3d12d3b8c5c1c2 Cr-Commit-Position: refs/heads/master@{#405191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Evan Stade
4 years, 5 months ago (2016-07-12 16:35:14 UTC) #2
Evan Stade
+ainslie
4 years, 5 months ago (2016-07-12 17:35:03 UTC) #4
msw
Yeah, bookmarks aren't *that* exciting :) lgtm.
4 years, 5 months ago (2016-07-12 18:42:37 UTC) #5
Evan Stade
On 2016/07/12 18:42:37, msw wrote: > Yeah, bookmarks aren't *that* exciting :) lgtm. http://www.theonion.com/article/stone-hearted-ice-witch-forgoes-exclamation-point-36005
4 years, 5 months ago (2016-07-12 18:47:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142103002/1
4 years, 5 months ago (2016-07-12 18:49:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/166482)
4 years, 5 months ago (2016-07-12 20:23:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142103002/1
4 years, 5 months ago (2016-07-13 16:39:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:45:44 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:45:49 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:47:28 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/21ab243152fed3cb57fadc8ccf3d12d3b8c5c1c2
Cr-Commit-Position: refs/heads/master@{#405191}

Powered by Google App Engine
This is Rietveld 408576698