Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21421002: Revert EVS revisions 209760, 298753, 213143. (Closed)

Created:
7 years, 4 months ago by hshi1
Modified:
7 years, 4 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert EVS revisions 209760, 298753, 213143. The EVS codepath is now dead. We will be using sheu@'s VEA path for HW-encoded screen capture. Revert "Encoded video capture: wire up key frame and bitrate settings." This reverts commit 348baf5a7b91cc4801dca5eae2921072055f35bc. Revert "Fix build failure with Android AOSP builds." This reverts commit ad526fe2ad101e249fe862b6e98c7d78ccdbc5ca. Revert "Define EncodedVideoSource and RtcCapturedEncodingVideoCapturer." This reverts commit 76bf7f58d93256dfa5867b6730e446517ead2a30. BUG=221441, 248334 TEST=trybot TBR=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216262

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep the little refactoring effort of find_delegate(). #

Patch Set 3 : Rebased at revision 215157 and resolved conflicts. #

Patch Set 4 : Rebased at 216225, prepare to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1362 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/content_message_generator.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D content/common/media/encoded_video_capture_messages.h View 1 chunk +0 lines, -135 lines 0 comments Download
M content/content_common.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 3 3 chunks +1 line, -19 lines 0 comments Download
D content/renderer/media/rtc_encoding_video_capturer.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/renderer/media/rtc_encoding_video_capturer.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D content/renderer/media/rtc_encoding_video_capturer_factory.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/renderer/media/rtc_encoding_video_capturer_factory.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M content/renderer/media/video_capture_impl.h View 5 chunks +1 line, -64 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 5 chunks +1 line, -201 lines 0 comments Download
M content/renderer/media/video_capture_impl_manager.h View 3 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/media/video_capture_impl_manager.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 1 3 chunks +0 lines, -51 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 1 3 chunks +1 line, -85 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ipc/ipc_message_start.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D media/base/encoded_bitstream_buffer.h View 1 chunk +0 lines, -52 lines 0 comments Download
D media/base/encoded_bitstream_buffer.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
D media/video/encoded_video_source.h View 1 chunk +0 lines, -79 lines 0 comments Download
D media/video/video_encode_types.h View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hshi1
Fischman@ and Sheu@ - PTAL. This is to remove dead code as requested. Now that ...
7 years, 4 months ago (2013-07-31 22:39:43 UTC) #1
Ami GONE FROM CHROMIUM
LGTM I'm fine with having sheu@'s LGTM gate this landing. https://codereview.chromium.org/21421002/diff/1/content/renderer/media/video_capture_message_filter.cc File content/renderer/media/video_capture_message_filter.cc (left): https://codereview.chromium.org/21421002/diff/1/content/renderer/media/video_capture_message_filter.cc#oldcode105 ...
7 years, 4 months ago (2013-07-31 23:38:59 UTC) #2
hshi1
https://codereview.chromium.org/21421002/diff/1/content/renderer/media/video_capture_message_filter.cc File content/renderer/media/video_capture_message_filter.cc (left): https://codereview.chromium.org/21421002/diff/1/content/renderer/media/video_capture_message_filter.cc#oldcode105 content/renderer/media/video_capture_message_filter.cc:105: VideoCaptureMessageFilter::Delegate* VideoCaptureMessageFilter::find_delegate( On 2013/07/31 23:38:59, Ami Fischman wrote: > ...
7 years, 4 months ago (2013-08-01 00:01:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/21421002/69001
7 years, 4 months ago (2013-08-07 20:04:39 UTC) #4
hshi1
7 years, 4 months ago (2013-08-07 20:35:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r216262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698