Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2142083002: Remove search::ShouldShowGoogleLocalNTP ("google_local_ntp" field trial flag) (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
markusheintz_, sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove search::ShouldShowGoogleLocalNTP ("google_local_ntp" field trial flag) It's always true in practice BUG=627483 Committed: https://crrev.com/27715e8803277108c464e20008b87632e28cfe50 Cr-Commit-Position: refs/heads/master@{#405104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M chrome/browser/search/local_ntp_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search/search.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/search/search.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Marc Treib
Baby steps...
4 years, 5 months ago (2016-07-12 16:08:30 UTC) #3
sfiera
LGTM
4 years, 5 months ago (2016-07-12 16:09:32 UTC) #4
markusheintz_
On 2016/07/12 16:09:32, sfiera wrote: > LGTM LGTM
4 years, 5 months ago (2016-07-13 08:21:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142083002/1
4 years, 5 months ago (2016-07-13 08:23:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 09:24:39 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 09:24:42 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 09:25:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27715e8803277108c464e20008b87632e28cfe50
Cr-Commit-Position: refs/heads/master@{#405104}

Powered by Google App Engine
This is Rietveld 408576698