Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2142053002: Addressed use-of-uninitialized-value bug for manage_accounts_button_ on L1044 (Closed)

Created:
4 years, 5 months ago by Jane
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Addressed use-of-uninitialized-value bug for manage_accounts_button_ on L1044 Tested with result "No crash found". BUG=627447 Committed: https://crrev.com/fd4804353b3d499e8000d31b6525e1f93aa48810 Cr-Commit-Position: refs/heads/master@{#405028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Jane
PTAL, thanks!
4 years, 5 months ago (2016-07-12 18:11:21 UTC) #4
msw
lgtm
4 years, 5 months ago (2016-07-12 18:45:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142053002/1
4 years, 5 months ago (2016-07-12 18:48:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/166435) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 19:18:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142053002/1
4 years, 5 months ago (2016-07-13 04:00:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 04:50:38 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:52:16 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd4804353b3d499e8000d31b6525e1f93aa48810
Cr-Commit-Position: refs/heads/master@{#405028}

Powered by Google App Engine
This is Rietveld 408576698