Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214203002: Fix type conversion issues for Android x64 (Closed)

Created:
6 years, 9 months ago by Zhenyu Liang
Modified:
6 years, 9 months ago
Reviewers:
Philippe, sky
CC:
chromium-reviews, craigdh+watch_chromium.org, dgrogan, alecflett, jam, ericu+idb_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, cmumford, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, jsbell+idb_chromium.org
Visibility:
Public.

Description

Fix type conversion issues for Android x64 BUG=346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/browser/memory_details_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/web_cache_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/android/file_poller/file_poller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Zhenyu Liang
6 years, 9 months ago (2014-03-27 03:28:18 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-27 15:48:45 UTC) #2
Philippe
lgtm too, thanks!
6 years, 9 months ago (2014-03-27 15:57:14 UTC) #3
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-27 17:37:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/214203002/1
6 years, 9 months ago (2014-03-27 17:37:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 19:56:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-27 19:56:21 UTC) #7
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-28 02:12:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/214203002/1
6 years, 9 months ago (2014-03-28 02:26:19 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 04:11:08 UTC) #10
Message was sent while issue was closed. 
Change committed as 260070

Powered by Google App Engine
This is Rietveld 408576698