base/trace_event/trace_event_impl.cc - Issue 2142023003: Binds two IDs together.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 2142023003: Binds two IDs together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests + inline documentation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_impl.cc

diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc

index f469f2f6bcbaa650c7a3263699a22729d742ece1..510cc2ffac6b32add118eb53ed4147b4b70369d9 100644

--- a/base/trace_event/trace_event_impl.cc

+++ b/base/trace_event/trace_event_impl.cc

@@ -368,7 +368,8 @@ void TraceEvent::AppendAsJSON(

StringAppendF(out, ",\"bp\":\"e\"");

if ((flags_ & TRACE_EVENT_FLAG_FLOW_OUT) ||

- (flags_ & TRACE_EVENT_FLAG_FLOW_IN)) {

+ (flags_ & TRACE_EVENT_FLAG_FLOW_IN) ||

+ phase_ == TRACE_EVENT_PHASE_BIND_IDS) {

StringAppendF(out, ",\"bind_id\":\"0x%" PRIx64 "\"",

static_cast<uint64_t>(bind_id_));

}