tools/SkShaper: SkStream->blob

tools/SkShaper: SkStream->blob

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142023002

Committed: https://skia.googlesource.com/skia/+/f119796f95f336d5b29f06f369b15b48a6a0df45

[hal.canary, 2016-07-12 14:51:11]

Description was changed from

==========
tools/SkShaper: SkStream->blob

BUG=skia:
==========

to

==========
tools/SkShaper: SkStream->blob

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142023002
==========

[hal.canary, 2016-07-12 14:51:30]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 14:51:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-12 14:52:27]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-07-12 14:52:28]

as promised

[commit-bot: I haz the power, 2016-07-12 15:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:04:53]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-07-12 15:31:44]

https://codereview.chromium.org/2142023002/diff/1/tools/SkShaper.cpp
File tools/SkShaper.cpp (right):

https://codereview.chromium.org/2142023002/diff/1/tools/SkShaper.cpp#newcode22
tools/SkShaper.cpp:22: std::unique_ptr<hb_blob_t, HBFBlobDel>
stream_to_blob(SkStreamAsset* assetPtr) {
if this is always going to take ownership of the stream then this should take
std::unique_ptr<SkStreamAsset> to document that, should it not? At some point
SkTypeface::openStream will get around to returning this type.

[hal.canary, 2016-07-12 15:32:39]

On 2016/07/12 15:31:44, bungeman-skia wrote:
> https://codereview.chromium.org/2142023002/diff/1/tools/SkShaper.cpp
> File tools/SkShaper.cpp (right):
> 
> https://codereview.chromium.org/2142023002/diff/1/tools/SkShaper.cpp#newcode22
> tools/SkShaper.cpp:22: std::unique_ptr<hb_blob_t, HBFBlobDel>
> stream_to_blob(SkStreamAsset* assetPtr) {
> if this is always going to take ownership of the stream then this should take
> std::unique_ptr<SkStreamAsset> to document that, should it not? At some point
> SkTypeface::openStream will get around to returning this type.

I originally wrote it that way.  I'll switch it back.

[hal.canary, 2016-07-12 15:35:03]

https://codereview.chromium.org/2142023002/diff/1/tools/SkShaper.cpp
File tools/SkShaper.cpp (right):

https://codereview.chromium.org/2142023002/diff/1/tools/SkShaper.cpp#newcode22
tools/SkShaper.cpp:22: std::unique_ptr<hb_blob_t, HBFBlobDel>
stream_to_blob(SkStreamAsset* assetPtr) {
On 2016/07/12 15:31:43, bungeman-skia wrote:
> if this is always going to take ownership of the stream then this should take
> std::unique_ptr<SkStreamAsset> to document that, should it not? At some point
> SkTypeface::openStream will get around to returning this type.

Done.

[bungeman-skia, 2016-07-12 15:39:33]

lgtm

[hal.canary, 2016-07-12 15:41:16]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-07-12 15:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 16:17:46]

Description was changed from

==========
tools/SkShaper: SkStream->blob

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142023002
==========

to

==========
tools/SkShaper: SkStream->blob

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142023002

Committed:
https://skia.googlesource.com/skia/+/f119796f95f336d5b29f06f369b15b48a6a0df45
==========

[commit-bot: I haz the power, 2016-07-12 16:17:47]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f119796f95f336d5b29f06f369b15b48a6a0df45

[commit-bot: I haz the power, 2016-07-12 16:17:48]

CQ bit was unchecked.