Fix :rfc1034identifier when the value contains underscore.

Fix :rfc1034identifier when the value contains underscore.

The :rfc1034identifier substitution converts invalid characters to '-'
because an underscore is invalid in an URL, however, if the value does
contain an underscore (like is the case for target_name in Chromium) it
is not replaced by a '-'.

Fix this by adding an '_' in the IDENT_RE. This cause the '_' to be
replaced by a '-' when using :rfc1034identifier and by a '_' when using
:identifier (i.e. no-operation).

BUG=625875
R=justincohen@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/e7079f0e0e14108ab0dba58728ff219637458563

[sdefresne, 2016-07-12 13:13:23]

sdefresne@chromium.org changed reviewers:
+ justincohen@google.com

[sdefresne, 2016-07-12 13:13:23]

Please take a look.

[justincohen, 2016-07-12 14:57:49]

justincohen@chromium.org changed reviewers:
+ justincohen@chromium.org

[justincohen, 2016-07-12 14:57:50]

lgtm

[sdefresne, 2016-07-12 15:48:13]

Description was changed from

==========
Fix :rfc1034identifier when the value contains underscore.

The :rfc1034identifier substitution converts invalid characters to '-'
because an underscore is invalid in an URL, however, if the value does
contain an underscore (like is the case for target_name in Chromium) it
is not replaced by a '-'.

Fix this by adding an '_' in the IDENT_RE. This cause the '_' to be
replaced by a '-' when using :rfc1034identifier and by a '_' when using
:identifier (i.e. no-operation).

BUG=625875
==========

to

==========
Fix :rfc1034identifier when the value contains underscore.

The :rfc1034identifier substitution converts invalid characters to '-'
because an underscore is invalid in an URL, however, if the value does
contain an underscore (like is the case for target_name in Chromium) it
is not replaced by a '-'.

Fix this by adding an '_' in the IDENT_RE. This cause the '_' to be
replaced by a '-' when using :rfc1034identifier and by a '_' when using
:identifier (i.e. no-operation).

BUG=625875
R=justincohen@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/e7079f0e0e14108ab0dba58728ff...
==========

[sdefresne, 2016-07-12 15:48:14]

Committed patchset #1 (id:1) manually as
e7079f0e0e14108ab0dba58728ff219637458563 (presubmit successful).