Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10032)

Unified Diff: chrome/utility/safe_browsing/mac/udif.h

Issue 2141963002: Validate safe_browsing::dmg::UDIFBlock data before attempting to read at its offsets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/safe_browsing/mac/hfs.cc ('k') | chrome/utility/safe_browsing/mac/udif.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/safe_browsing/mac/udif.h
diff --git a/chrome/utility/safe_browsing/mac/udif.h b/chrome/utility/safe_browsing/mac/udif.h
index 3b1a29d5280bb3d5a4d3f70d46ca62bea9e869f3..023a8729d1260e78e1d22c2c17d8feca6c52999a 100644
--- a/chrome/utility/safe_browsing/mac/udif.h
+++ b/chrome/utility/safe_browsing/mac/udif.h
@@ -76,11 +76,6 @@ class UDIFParser {
// Parses the blkx plist trailer structure.
bool ParseBlkx();
- // Reads the data pointed to by the block |chunk|, decompressing it as
- // necessary, into the out-buffer |decompressed_data|.
- bool ReadBlockChunk(const UDIFBlockChunk* chunk,
- std::vector<uint8_t>* decompressed_data);
-
ReadStream* const stream_; // The stream backing the UDIF image. Weak.
std::vector<std::string> partition_names_; // The names of all partitions.
ScopedVector<const UDIFBlock> blocks_; // All blocks in the UDIF image.
« no previous file with comments | « chrome/utility/safe_browsing/mac/hfs.cc ('k') | chrome/utility/safe_browsing/mac/udif.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698