chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc - Issue 2141933002: Split NTP_TILE_LOADED event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 2141933002: Split NTP_TILE_LOADED event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

index dbdedebf18469d0a88e1338a7d71ea91477bb29e..43d9cbc71740667f1f454333e559c0b770c0875d 100644

--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

@@ -52,13 +52,13 @@ TEST_F(NTPUserDataLoggerTest, TestLogging) {

logger.LogEvent(NTP_TILE, delta);

logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION, delta);

- logger.EmitNtpStatistics(NTPUserDataLogger::EmitReason::NAVIGATED_AWAY);

+ logger.LogEvent(NTP_ALL_TILES_LOADED, delta);

EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));

EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8));

// Statistics should be reset to 0, so we should not log anything else.

- logger.EmitNtpStatistics(NTPUserDataLogger::EmitReason::NAVIGATED_AWAY);

+ logger.LogEvent(NTP_ALL_TILES_LOADED, delta);

EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));

}