Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/common/search/ntp_logging_events.h

Issue 2141933002: Split NTP_TILE_LOADED event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_ 5 #ifndef CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_
6 #define CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_ 6 #define CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_
7 7
8 // The different types of events that are logged from the NTP. This enum is used 8 // The different types of events that are logged from the NTP. This enum is used
9 // to transfer information from the NTP javascript to the renderer and is not 9 // to transfer information from the NTP javascript to the renderer and is not
10 // used as a UMA enum histogram's logged value. 10 // used as a UMA enum histogram's logged value.
(...skipping 25 matching lines...) Expand all
36 // Deleted: NTP_THUMBNAIL_ERROR = 6, 36 // Deleted: NTP_THUMBNAIL_ERROR = 6,
37 37
38 // Used a gray tile with the domain as the fallback for a failed thumbnail. 38 // Used a gray tile with the domain as the fallback for a failed thumbnail.
39 // Deleted: NTP_GRAY_TILE_FALLBACK = 7, 39 // Deleted: NTP_GRAY_TILE_FALLBACK = 7,
40 40
41 // The visuals of that tile's fallback are handled externally. 41 // The visuals of that tile's fallback are handled externally.
42 // Deleted: NTP_EXTERNAL_TILE_FALLBACK = 8, 42 // Deleted: NTP_EXTERNAL_TILE_FALLBACK = 8,
43 43
44 // Deleted: NTP_MOUSEOVER = 9 44 // Deleted: NTP_MOUSEOVER = 9
45 45
46 // A NTP Tile has finished loading (successfully or failing). 46 // A NTP Tile has finished loading (successfully or failing). Logged only by
47 // the multi-iframe version of the NTP.
47 NTP_TILE_LOADED = 10, 48 NTP_TILE_LOADED = 10,
48 49
49 NTP_EVENT_TYPE_LAST = NTP_TILE_LOADED 50 // All NTP tiles have finished loading (successfully or failing). Logged only
51 // by the single-iframe version of the NTP.
52 NTP_ALL_TILES_LOADED = 11,
53
54 NTP_EVENT_TYPE_LAST = NTP_ALL_TILES_LOADED
50 }; 55 };
51 56
52 // The source of an NTP tile. 57 // The source of an NTP tile.
53 // Note: Keep in sync with browser/resources/local_ntp/most_visited_util.js and 58 // Note: Keep in sync with browser/resources/local_ntp/most_visited_util.js and
54 // browser/resources/local_ntp/most_visited_single.js. 59 // browser/resources/local_ntp/most_visited_single.js.
55 // TODO(treib): Merge this into MostVisitedSource from components/ntp_tiles. 60 // TODO(treib): Merge this into MostVisitedSource from components/ntp_tiles.
56 enum class NTPLoggingTileSource { 61 enum class NTPLoggingTileSource {
57 CLIENT = 0, 62 CLIENT = 0,
58 SERVER = 1, 63 SERVER = 1,
59 LAST = SERVER 64 LAST = SERVER
60 }; 65 };
61 66
62 #endif // CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_ 67 #endif // CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698