[gn] Let gyp/gn comparison be more verbose on error

[gn] Let gyp/gn comparison be more verbose on error

The step fails on windows. This'll help investigating why.

BUG=chromium:474921
TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true

Committed: https://crrev.com/1e978ec00a1d812cd1901bb615ce50f0675e0966
Cr-Commit-Position: refs/heads/master@{#37675}

[Michael Achenbach, 2016-07-12 10:25:02]

Description was changed from

==========
[gn] Let gyp/gn comparison be more verbose on error

BUG=
==========

to

==========
[gn] Let gyp/gn comparison be more verbose on error

The step fails on windows. This'll help investigating why.

BUG=chromium:474921
TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true
==========

[Michael Achenbach, 2016-07-12 10:25:02]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, tandrii@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-07-12 10:25:12]

PTAL

[tandrii(chromium), 2016-07-12 10:59:01]

LGTM % comment

https://codereview.chromium.org/2141903002/diff/1/tools/gyp_flag_compare.py
File tools/gyp_flag_compare.py (right):

https://codereview.chromium.org/2141903002/diff/1/tools/gyp_flag_compare.py#n...
tools/gyp_flag_compare.py:193: # Rescue the output we got until the exception
happened.
this will only print stdout though. Stderr has already been printed.
Maybe you want to also print some separation lines, just to be clear?

[Michael Achenbach, 2016-07-12 11:11:38]

https://codereview.chromium.org/2141903002/diff/1/tools/gyp_flag_compare.py
File tools/gyp_flag_compare.py (right):

https://codereview.chromium.org/2141903002/diff/1/tools/gyp_flag_compare.py#n...
tools/gyp_flag_compare.py:193: # Rescue the output we got until the exception
happened.
On 2016/07/12 10:59:01, tandrii(chromium) wrote:
> this will only print stdout though. Stderr has already been printed.
> Maybe you want to also print some separation lines, just to be clear?

Done.

[Michael Achenbach, 2016-07-12 11:14:12]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-07-12 11:14:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2141903002/#ps20001
(title: "Review")

[commit-bot: I haz the power, 2016-07-12 11:14:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 11:17:07]

Description was changed from

==========
[gn] Let gyp/gn comparison be more verbose on error

The step fails on windows. This'll help investigating why.

BUG=chromium:474921
TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true
==========

to

==========
[gn] Let gyp/gn comparison be more verbose on error

The step fails on windows. This'll help investigating why.

BUG=chromium:474921
TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true
==========

[commit-bot: I haz the power, 2016-07-12 11:17:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 11:18:48]

Description was changed from

==========
[gn] Let gyp/gn comparison be more verbose on error

The step fails on windows. This'll help investigating why.

BUG=chromium:474921
TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true
==========

to

==========
[gn] Let gyp/gn comparison be more verbose on error

The step fails on windows. This'll help investigating why.

BUG=chromium:474921
TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true

Committed: https://crrev.com/1e978ec00a1d812cd1901bb615ce50f0675e0966
Cr-Commit-Position: refs/heads/master@{#37675}
==========

[commit-bot: I haz the power, 2016-07-12 11:18:49]

Patchset 2 (id:??) landed as
https://crrev.com/1e978ec00a1d812cd1901bb615ce50f0675e0966
Cr-Commit-Position: refs/heads/master@{#37675}