Add helper functions to get per-frame task runners

Add helper functions to get per-frame task runners

This CL introduces TaskRunnerHelper that collects helper functions to get task runners.

This CL removes code to look up task runners of m_importsController and m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689
Committed: https://crrev.com/453e03e72d02fb698ba2eee8550245928a8ab3a5
Cr-Commit-Position: refs/heads/master@{#404946}

[haraken, 2016-07-12 06:06:50]

haraken@chromium.org changed reviewers:
+ alexclarke@chromium.org, dcheng@chromium.org, hiroshige@chromium.org,
skyostil@chromium.org, tzik@chromium.org

[haraken, 2016-07-12 06:06:51]

PTAL

The goal is to replace all
Platform::current()->current/mainThread()->(scheduler()->)... things in the code
base with the helper functions in this CL. What do you think?

[alex clarke (OOO till 29th), 2016-07-12 09:10:30]

I'd be tempted to organize the helpers in a class (as static members) but
otherwise this seems OK.

[haraken, 2016-07-12 10:40:17]

Description was changed from

==========
Add helper functions to get per-frame task runners

This CL adds the following helper functions:

getUnthrottleTaskRunner(LocalFrame*)
getTimerTaskRunner(LocalFrame*)
getLoadingTaskRunner(LocalFrame*)
getUnthrottleTaskRunner(Document*)
getTimerTaskRunner(Document*)
getLoadingTaskRunner(Document*)

This CL removes code to look up task runners of m_importsController and
m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689
==========

to

==========
Add helper functions to get per-frame task runners

This CL introduces TaskRunnerHelper that collects helper functions to get task
runners.

This CL removes code to look up task runners of m_importsController and
m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689
==========

[haraken, 2016-07-12 10:40:28]

On 2016/07/12 09:10:30, alex clarke wrote:
> I'd be tempted to organize the helpers in a class (as static members) but
> otherwise this seems OK.

Fixed. PTAL.

[alex clarke (OOO till 29th), 2016-07-12 12:34:07]

I think this patch is missing the new files :)

[haraken, 2016-07-12 13:42:57]

On 2016/07/12 12:34:07, alex clarke wrote:
> I think this patch is missing the new files :)

Sorry, added :)

[alex clarke (OOO till 29th), 2016-07-12 13:44:16]

Non-owner LGTM

[haraken, 2016-07-13 00:04:39]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:16:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:16:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[haraken, 2016-07-13 02:19:25]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:22:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 03:16:21]

Description was changed from

==========
Add helper functions to get per-frame task runners

This CL introduces TaskRunnerHelper that collects helper functions to get task
runners.

This CL removes code to look up task runners of m_importsController and
m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689
==========

to

==========
Add helper functions to get per-frame task runners

This CL introduces TaskRunnerHelper that collects helper functions to get task
runners.

This CL removes code to look up task runners of m_importsController and
m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689
==========

[commit-bot: I haz the power, 2016-07-13 03:16:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 03:18:44]

Description was changed from

==========
Add helper functions to get per-frame task runners

This CL introduces TaskRunnerHelper that collects helper functions to get task
runners.

This CL removes code to look up task runners of m_importsController and
m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689
==========

to

==========
Add helper functions to get per-frame task runners

This CL introduces TaskRunnerHelper that collects helper functions to get task
runners.

This CL removes code to look up task runners of m_importsController and
m_contextDocument
(I don't think it's needed; we can just fall back to the default task runner
when document->frame() is not available).

BUG=624689

Committed: https://crrev.com/453e03e72d02fb698ba2eee8550245928a8ab3a5
Cr-Commit-Position: refs/heads/master@{#404946}
==========

[commit-bot: I haz the power, 2016-07-13 03:18:45]

Patchset 3 (id:??) landed as
https://crrev.com/453e03e72d02fb698ba2eee8550245928a8ab3a5
Cr-Commit-Position: refs/heads/master@{#404946}