third_party/WebKit/LayoutTests/web-animations-api/timed-item.html - Issue 2141863002: Rename TimedItem => ComputedTimingProperties and Timing => AnimationEffectTiming in test

Unified Diff: third_party/WebKit/LayoutTests/web-animations-api/timed-item.html

Issue 2141863002: Rename TimedItem => ComputedTimingProperties and Timing => AnimationEffectTiming in test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/web-animations-api/timed-item.html

diff --git a/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html b/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html

index 10fd0c761a22678beb587e78e18e03e8fb611c67..681404fc54b97b43e53f0b824bec560d48fa98a8 100644

--- a/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html

+++ b/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html

@@ -1,6 +1,9 @@

<!DOCTYPE html>

+<title>Things</title>

+<link rel="https://w3c.github.io/web-animations/#the-animation-interface">

nainar 2016/07/12 05:30:33 Should be: https://www.w3.org/TR/web-animations/#t

suzyh_UTC10 (ex-contributor) 2016/07/12 05:39:54 Except from a base of https://w3c.github.io/web-an

nainar 2016/07/12 05:47:31 Done.

+<script src="../imported/wpt/web-animations/testcommon.js"></script>

suzyh_UTC10 (ex-contributor) 2016/07/12 05:18:06 Are you using this testcommon script?

nainar 2016/07/12 05:30:33 should I change the ones that are comparing times

suzyh_UTC10 (ex-contributor) 2016/07/12 05:39:54 Oh, good point. Yeah, I guess convert to use asser

nainar 2016/07/12 05:47:31 Done.

<body>

@@ -31,7 +34,7 @@ test(function() {

animation.currentTime = 7000;

assert_equals(keyframeEffect.getComputedTiming().localTime, 7000);

assert_equals(keyframeEffect.getComputedTiming().currentIteration, 2);

-}, 'TimedItem.localTime and TimedItem.currentIteration return reasonable values when an keyframeEffect is in effect');

+}, 'ComputedTimingProperties.localTime and ComputedTimingProperties.currentIteration return reasonable values when an keyframeEffect is in effect');

test(function() {

var animation = element.animate(keyframes);

@@ -40,26 +43,26 @@ test(function() {

assert_equals(keyframeEffect.getComputedTiming().currentIteration, null);

animation.currentTime = 1;

assert_equals(keyframeEffect.getComputedTiming().currentIteration, null);

-}, 'TimedItem.currentIteration is null when keyframeEffect is not in effect');

+}, 'ComputedTimingProperties.currentIteration is null when keyframeEffect is not in effect');

test(function() {

var keyframeEffect = new KeyframeEffect(element, keyframes, 2);

assert_equals(keyframeEffect.getComputedTiming().endTime, 2);

assert_equals(keyframeEffect.getComputedTiming().duration, 2);

assert_equals(keyframeEffect.getComputedTiming().activeDuration, 2);

-}, 'TimedItem startTime, endTime, duration, activeDuration are sensible for a simple keyframeEffect');

+}, 'ComputedTimingProperties startTime, endTime, duration, activeDuration are sensible for a simple keyframeEffect');

test(function() {

var keyframeEffect = new KeyframeEffect(element, keyframes, {duration: 3, iterations: 4, delay: 5});

assert_equals(keyframeEffect.getComputedTiming().endTime, 17);

assert_equals(keyframeEffect.getComputedTiming().duration, 3);

assert_equals(keyframeEffect.getComputedTiming().activeDuration, 12);

-}, 'TimedItem startTime, endTime, duration, activeDuration are sensible for keyframeEffects with delays and iterations');

+}, 'ComputedTimingProperties startTime, endTime, duration, activeDuration are sensible for keyframeEffects with delays and iterations');

test(function() {

var keyframeEffect = new KeyframeEffect(element, keyframes, {delay: 1});

assert_equals(keyframeEffect.getComputedTiming().duration, 0);

-}, 'TimedItem duration is calculated when no duration is specified');

+}, 'ComputedTimingProperties duration is calculated when no duration is specified');

test(function() {

var timing = new KeyframeEffect(element, keyframes).timing;

@@ -67,6 +70,6 @@ test(function() {

assert_throws(new TypeError, function() { timing[attr] = NaN; }, attr);

assert_throws(new TypeError, function() { timing[attr] = Infinity; }, attr);

}

-}, 'Restricted double attributes on the Timing interface throws for non-finite values.');

+}, 'Restricted double attributes on the AnimationEffectTiming interface throws for non-finite values.');

</script>

« no previous file with comments | « no previous file | no next file » | no next file with comments »