Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2141863002: Rename TimedItem => ComputedTimingProperties and Timing => AnimationEffectTiming in test (Closed)

Created:
4 years, 5 months ago by nainar
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TimedItem => ComputedTimingProperties and Timing => AnimationEffectTiming in test BUG=623437 Committed: https://crrev.com/1121153c958ea45a0bdadcdbb127a0b1e51daa5f Cr-Commit-Position: refs/heads/master@{#404791}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Review #

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -89 lines) Patch
A + third_party/WebKit/LayoutTests/web-animations-api/effect-of-keyframeeffect-on-getComputedTiming.html View 1 4 chunks +20 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/web-animations-api/timed-item.html View 1 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
nainar
The only other test for getComputedTiming() is https://github.com/w3c/web-platform-tests/blob/fa55abc4c96aa63a39229edd2fb469241e64689a/web-animations/interfaces/KeyframeEffect/getComputedTiming.html and it doesnt cover these cases ->hence ...
4 years, 5 months ago (2016-07-12 05:02:07 UTC) #3
suzyh_UTC10 (ex-contributor)
Can you recommend a new filename for the test and its path in the web-platform-tests ...
4 years, 5 months ago (2016-07-12 05:18:06 UTC) #4
nainar
Suggested folder: interfaces/KeyframeEffect (mentioned in the sheet to now) Suggested name: effect-of-keyframeeffect-on-getComputedTiming ? https://codereview.chromium.org/2141863002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html File ...
4 years, 5 months ago (2016-07-12 05:30:33 UTC) #5
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/2141863002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html File third_party/WebKit/LayoutTests/web-animations-api/timed-item.html (right): https://codereview.chromium.org/2141863002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html#newcode3 third_party/WebKit/LayoutTests/web-animations-api/timed-item.html:3: <link rel="https://w3c.github.io/web-animations/#the-animation-interface"> On 2016/07/12 at 05:30:33, nainar wrote: > ...
4 years, 5 months ago (2016-07-12 05:39:54 UTC) #6
nainar
https://codereview.chromium.org/2141863002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html File third_party/WebKit/LayoutTests/web-animations-api/timed-item.html (right): https://codereview.chromium.org/2141863002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html#newcode3 third_party/WebKit/LayoutTests/web-animations-api/timed-item.html:3: <link rel="https://w3c.github.io/web-animations/#the-animation-interface"> Done. https://codereview.chromium.org/2141863002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/timed-item.html#newcode6 third_party/WebKit/LayoutTests/web-animations-api/timed-item.html:6: <script src="../imported/wpt/web-animations/testcommon.js"></script> Done.
4 years, 5 months ago (2016-07-12 05:47:31 UTC) #7
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 05:49:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141863002/40001
4 years, 5 months ago (2016-07-12 05:51:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-12 07:24:05 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 07:24:07 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 07:25:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1121153c958ea45a0bdadcdbb127a0b1e51daa5f
Cr-Commit-Position: refs/heads/master@{#404791}

Powered by Google App Engine
This is Rietveld 408576698