Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2141853002: Delete test and move code to new file startTime.html (Closed)

Created:
4 years, 5 months ago by nainar
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete test and move code to new file startTime.html Delete test and move to startTime.html. Added a comment in a div to note that this will need to be upstreamed to w3c test later. BUG=623437 Committed: https://crrev.com/6e823ea25efc4d9143dbe042a79b6efc3fe191ac Cr-Commit-Position: refs/heads/master@{#404888}

Patch Set 1 #

Patch Set 2 : copy test over #

Total comments: 4

Patch Set 3 : add expectation #

Patch Set 4 : For review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -17 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/player-unresolved-times.html View 1 chunk +0 lines, -17 lines 0 comments Download
A third_party/WebKit/LayoutTests/web-animations-api/startTime.html View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/web-animations-api/startTime-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
nainar
Made the change as per our discussion - sorry about the repeated clarifications!
4 years, 5 months ago (2016-07-12 01:46:25 UTC) #3
nainar
Sending back your way
4 years, 5 months ago (2016-07-12 02:55:01 UTC) #5
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/2141853002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/startTime.html File third_party/WebKit/LayoutTests/web-animations-api/startTime.html (right): https://codereview.chromium.org/2141853002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/startTime.html#newcode8 third_party/WebKit/LayoutTests/web-animations-api/startTime.html:8: <script src="../../testcommon.js"></script> In order to make this test run ...
4 years, 5 months ago (2016-07-12 03:26:07 UTC) #6
nainar
I assume you will need a diff between the startTime.html in imported and here - ...
4 years, 5 months ago (2016-07-12 05:11:00 UTC) #7
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 05:14:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141853002/60001
4 years, 5 months ago (2016-07-12 05:15:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253799)
4 years, 5 months ago (2016-07-12 06:11:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141853002/60001
4 years, 5 months ago (2016-07-12 06:30:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260720)
4 years, 5 months ago (2016-07-12 08:12:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141853002/60001
4 years, 5 months ago (2016-07-12 23:20:54 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 02:07:19 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:08:50 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6e823ea25efc4d9143dbe042a79b6efc3fe191ac
Cr-Commit-Position: refs/heads/master@{#404888}

Powered by Google App Engine
This is Rietveld 408576698