Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2141833002: Rename the test and use testcommon.js (Closed)

Created:
4 years, 5 months ago by nainar
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the test and use testcommon.js BUG=623437 Committed: https://crrev.com/bd1fa793c46bba22f4d81a1ea7eb0a82b8044746 Cr-Commit-Position: refs/heads/master@{#405413}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a failing test expectations #

Total comments: 5

Patch Set 3 : Review #

Total comments: 3

Patch Set 4 : expectation filename changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
A third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only-expected.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/player-source-becomes-longer.html View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
nainar
PTAL? Thanks!
4 years, 5 months ago (2016-07-12 01:30:15 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/2141833002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html File third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html (right): https://codereview.chromium.org/2141833002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html#newcode17 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html:17: animation.effect.timing.duration = 1500; The effect on the Animation interface ...
4 years, 5 months ago (2016-07-12 03:39:10 UTC) #4
nainar
https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html File third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html (right): https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html#newcode15 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html:15: test(function() { Should this test be removed then?
4 years, 5 months ago (2016-07-12 04:44:29 UTC) #5
alancutter (OOO until 2018)
https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html File third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html (right): https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html#newcode13 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html:13: }, 'animation.effect should be rea'); Reeeeeeeeeeeeeeeeeeeeeeeea. https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html#newcode15 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html:15: test(function() ...
4 years, 5 months ago (2016-07-12 05:43:47 UTC) #6
nainar
https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html File third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html (right): https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html#newcode13 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html:13: }, 'animation.effect should be rea'); pants https://codereview.chromium.org/2141833002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html#newcode15 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer.html:15: test(function() ...
4 years, 5 months ago (2016-07-12 06:02:53 UTC) #7
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/2141833002/diff/40001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt File third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt (right): https://codereview.chromium.org/2141833002/diff/40001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt#newcode2 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt:2: FAIL Extending effect should not cause a change in ...
4 years, 5 months ago (2016-07-13 22:59:52 UTC) #9
alancutter (OOO until 2018)
https://codereview.chromium.org/2141833002/diff/40001/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only.html File third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only.html (right): https://codereview.chromium.org/2141833002/diff/40001/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only.html#newcode11 third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only.html:11: animation.effect.timing.duration = 1500; Attempting to write to a readonly ...
4 years, 5 months ago (2016-07-13 23:30:33 UTC) #10
nainar
Sending back for the Animation team to take over. https://codereview.chromium.org/2141833002/diff/40001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt File third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt (right): https://codereview.chromium.org/2141833002/diff/40001/third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt#newcode2 third_party/WebKit/LayoutTests/web-animations-api/animation-source-becomes-longer-expected.txt:2: ...
4 years, 5 months ago (2016-07-13 23:54:32 UTC) #11
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-14 01:05:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141833002/60001
4 years, 5 months ago (2016-07-14 01:06:05 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 02:44:15 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 02:48:22 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/bd1fa793c46bba22f4d81a1ea7eb0a82b8044746
Cr-Commit-Position: refs/heads/master@{#405413}

Powered by Google App Engine
This is Rietveld 408576698