mojo/bindings/js/core_unittests.js - Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/bindings/js/core_unittests.js

Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rm.extra.gc Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/bindings/js/core_unittests.js

diff --git a/mojo/bindings/js/core_unittests.js b/mojo/bindings/js/core_unittests.js

index a05a5b200f119935572372baa1f4024f57a77705..62b20d1ac66d4b3091de8e0b4930ba3fabe3c1b5 100644

--- a/mojo/bindings/js/core_unittests.js

+++ b/mojo/bindings/js/core_unittests.js

@@ -5,11 +5,13 @@

define([

"gin/test/expect",

"mojo/bindings/js/core",

- ], function(expect, core) {

+ "gc",

+ ], function(expect, core, gc) {

runWithMessagePipe(testNop);

runWithMessagePipe(testReadAndWriteMessage);

runWithDataPipe(testNop);

runWithDataPipe(testReadAndWriteDataPipe);

+ gc.collectGarbage(); // should not crash

this.result = "PASS";

function runWithMessagePipe(test) {

« mojo/bindings/js/core.cc ('K') | « mojo/bindings/js/core.cc ('k') | mojo/bindings/js/handle.h » ('j') | no next file with comments »