gin/test/file_runner.cc - Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/test/file_runner.cc

Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rm.extra.gc Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/test/file_runner.cc

diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc

index 86cb2f34b8e9400c1ef274531e651dbd7f17bbd4..858fb3923301a28768e23efc83b7772b3518ef36 100644

--- a/gin/test/file_runner.cc

+++ b/gin/test/file_runner.cc

@@ -12,6 +12,7 @@

#include "gin/modules/module_registry.h"

#include "gin/public/context_holder.h"

#include "gin/public/isolate_holder.h"

+#include "gin/test/gc.h"

#include "gin/test/gtest.h"

#include "gin/try_catch.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -34,6 +35,7 @@ FileRunnerDelegate::FileRunnerDelegate()

: ModuleRunnerDelegate(GetModuleSearchPaths()) {

AddBuiltinModule(Console::kModuleName, Console::GetModule);

AddBuiltinModule(GTest::kModuleName, GTest::GetModule);

+ AddBuiltinModule(GC::kModuleName, GC::GetModule);

}

FileRunnerDelegate::~FileRunnerDelegate() {

« no previous file with comments | « gin/gin.gyp ('k') | gin/test/gc.h » ('j') | mojo/bindings/js/core.cc » ('J')