Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: gin/test/gtest.cc

Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/test/gtest.cc
diff --git a/gin/test/gtest.cc b/gin/test/gtest.cc
index b4060a3b591f61727d80d9f6e2a0e10167e32df2..4091f51dced0d5e790d5259356481be4c693aabd 100644
--- a/gin/test/gtest.cc
+++ b/gin/test/gtest.cc
@@ -53,6 +53,7 @@ v8::Local<v8::Value> GTest::GetModule(v8::Isolate* isolate) {
.SetMethod("expectTrue", ExpectTrue)
.SetMethod("expectFalse", ExpectFalse)
.SetMethod("expectEqual", ExpectEqual)
+ .SetMethod("collectGarbage", v8::V8::LowMemoryNotification)
abarth-chromium 2014/03/29 01:56:17 Did you mean to expose this function in two places
Matt Perry 2014/03/31 19:34:17 Oops, thanks. I put it here first as a hack. Remov
.Build();
data->SetObjectTemplate(&g_wrapper_info, templ);
}
« no previous file with comments | « gin/test/gc.cc ('k') | mojo/bindings/js/core.cc » ('j') | mojo/bindings/js/core.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698