Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: mojo/bindings/js/handle.cc

Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm.extra.gc Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« mojo/bindings/js/core.cc ('K') | « mojo/bindings/js/handle.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/bindings/js/handle.h" 5 #include "mojo/bindings/js/handle.h"
6 6
7 namespace gin { 7 namespace gin {
8 8
9 gin::WrapperInfo HandleWrapper::kWrapperInfo = { gin::kEmbedderNativeGin };
10
11 HandleWrapper::HandleWrapper(MojoHandle handle)
12 : handle_(mojo::Handle(handle)) {
13 }
14
15 HandleWrapper::~HandleWrapper() {
16 }
17
9 v8::Handle<v8::Value> Converter<mojo::Handle>::ToV8(v8::Isolate* isolate, 18 v8::Handle<v8::Value> Converter<mojo::Handle>::ToV8(v8::Isolate* isolate,
10 const mojo::Handle& val) { 19 const mojo::Handle& val) {
11 return Converter<MojoHandle>::ToV8(isolate, val.value()); 20 return HandleWrapper::Create(isolate, val.value()).ToV8();
12 } 21 }
13 22
14 bool Converter<mojo::Handle>::FromV8(v8::Isolate* isolate, 23 bool Converter<mojo::Handle>::FromV8(v8::Isolate* isolate,
15 v8::Handle<v8::Value> val, 24 v8::Handle<v8::Value> val,
16 mojo::Handle* out) { 25 mojo::Handle* out) {
17 return Converter<MojoHandle>::FromV8(isolate, val, out->mutable_value()); 26 gin::Handle<HandleWrapper> handle;
27 if (!Converter<gin::Handle<HandleWrapper> >::FromV8(isolate, val, &handle))
28 return false;
29
30 *out = handle->get();
31 return true;
18 } 32 }
19 33
20 } // namespace gin 34 } // namespace gin
OLDNEW
« mojo/bindings/js/core.cc ('K') | « mojo/bindings/js/handle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698