Prepare animation-finish-event-cancelled for upstreaming

Prepare animation-finish-event-cancelled for upstreaming

BUG=623437
Committed: https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d
Cr-Commit-Position: refs/heads/master@{#405095}

[dstockwell, 2016-07-12 01:57:48]

dstockwell@chromium.org changed reviewers:
+ alancutter@chromium.org, suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-07-12 02:03:50]

lgtm

[alancutter (OOO until 2018), 2016-07-12 03:54:01]

lgtm with nits.

I wish there was a nicer way to orchestrate the timing of this test.

https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html
(right):

https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html:11:
var anim3 = document.body.animate([], 100000);
Use Infinity for duration.

https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html:15:
anim1.onfinish = function() {
We should use the finished promise as that is preferred in the WPTs.

[alancutter (OOO until 2018), 2016-07-12 04:19:28]

On 2016/07/12 at 03:54:01, alancutter wrote:
> lgtm with nits.
> 
> I wish there was a nicer way to orchestrate the timing of this test.

Turns out there's a nicer way, just listen to finished promise being rejected
(fulfilment is failure).

[alancutter (OOO until 2018), 2016-07-12 04:38:25]

https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html
(right):

https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html:23:
assert_true(false);
Use t.unreached_func('message').
Wrap this entire test in async_test(t => { <test> }, description);

[suzyh_UTC10 (ex-contributor), 2016-07-13 07:30:06]

On 2016/07/12 at 04:38:25, alancutter wrote:
>
https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html
(right):
> 
>
https://codereview.chromium.org/2141823002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html:23:
assert_true(false);
> Use t.unreached_func('message').
> Wrap this entire test in async_test(t => { <test> }, description);

I'll trigger this patch to commit and address these comments in a follow-up
patch, since the burndown is now over.

[suzyh_UTC10 (ex-contributor), 2016-07-13 07:30:09]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-07-13 07:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:52:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 08:52:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 08:55:45]

Description was changed from

==========
Prepare animation-finish-event-cancelled for upstreaming

BUG=623437
==========

to

==========
Prepare animation-finish-event-cancelled for upstreaming

BUG=623437

Committed: https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d
Cr-Commit-Position: refs/heads/master@{#405095}
==========

[commit-bot: I haz the power, 2016-07-13 08:55:46]

Patchset 1 (id:??) landed as
https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d
Cr-Commit-Position: refs/heads/master@{#405095}