Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2141813002: Compile asm->wasm conversion at parse time. (Closed)

Created:
4 years, 5 months ago by bradnelson
Modified:
4 years, 5 months ago
Reviewers:
Mircea Trofin, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Compile asm->wasm conversion at parse time. Move compiltion of asm.js code to parse time. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=asm-wasm R=mtrofin@chromium.org LOG=N Committed: https://crrev.com/d10f42247aad219cc84325093aad3a3be30ae553 Cr-Commit-Position: refs/heads/master@{#37695}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M src/asmjs/asm-js.cc View 2 chunks +9 lines, -22 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
bradn
Hi Mircea. This has failures for two tests. mjsunit/asm/* --extra-flags=--validate-asm There's likely a race involved, ...
4 years, 5 months ago (2016-07-12 01:01:22 UTC) #2
Mircea Trofin
lgtm https://codereview.chromium.org/2141813002/diff/1/src/asmjs/asm-js.cc File src/asmjs/asm-js.cc (right): https://codereview.chromium.org/2141813002/diff/1/src/asmjs/asm-js.cc#newcode79 src/asmjs/asm-js.cc:79: CompileModule(info->isolate(), module->begin(), module->end(), &thrower, To echo our chat ...
4 years, 5 months ago (2016-07-12 22:07:34 UTC) #3
bradn
It will have impact, but only for now with this flag on. We should definitely ...
4 years, 5 months ago (2016-07-12 22:34:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141813002/1
4 years, 5 months ago (2016-07-12 22:35:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 23:10:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 23:12:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d10f42247aad219cc84325093aad3a3be30ae553
Cr-Commit-Position: refs/heads/master@{#37695}

Powered by Google App Engine
This is Rietveld 408576698