Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2141783002: Remove obsolete flag. (Closed)

Created:
4 years, 5 months ago by Peter Wen
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete flags. - Remove command line flags enable-toolbar-swipe-in-document-mode and enable-tab-switcher-in-document-mode. - Several corresponding methods in FeatureUtilities have become obsolete as it is no longer possible to have the tab switcher enabled in document mode. BUG=612245 Committed: https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23 Cr-Commit-Position: refs/heads/master@{#405177}

Patch Set 1 #

Patch Set 2 : Opps forgot java side. #

Patch Set 3 : More thorough deletion. #

Patch Set 4 : Remove obsolete if condition. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -86 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/device/DeviceClassManager.java View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 2 3 4 2 chunks +3 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
Peter Wen
Not used anymore.
4 years, 5 months ago (2016-07-11 21:21:38 UTC) #2
gone
lgtm % changing the commit message to actually describe what you're deleting Thought you were ...
4 years, 5 months ago (2016-07-11 21:35:01 UTC) #3
Peter Wen
On 2016/07/11 21:35:01, dfalcantara wrote: > lgtm % changing the commit message to actually describe ...
4 years, 5 months ago (2016-07-11 21:43:27 UTC) #5
gone
Geez that's a lot extra. Still lgtm, I think.
4 years, 5 months ago (2016-07-11 21:53:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141783002/40001
4 years, 5 months ago (2016-07-12 15:22:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141783002/60001
4 years, 5 months ago (2016-07-12 18:39:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191604) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 19:06:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141783002/60001
4 years, 5 months ago (2016-07-13 15:20:18 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/192533) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-13 15:24:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141783002/80001
4 years, 5 months ago (2016-07-13 15:33:17 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-13 16:17:20 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:17:26 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:20:41 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23
Cr-Commit-Position: refs/heads/master@{#405177}

Powered by Google App Engine
This is Rietveld 408576698