third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html - Issue 2141743002: Use node() when generating element id's

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html

Issue 2141743002: Use node() when generating element id's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer feedback. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 div {

	4 width: 100px;

	5 height: 100px;

	6 background: orange;

	7 }

	8 div::before {

	9 content: ":)";

	10 transition-property: transform;

	11 transition-duration: 1ms;

	12

	13 /* Make the pseudo element "transformable" as per

	14 * https://www.w3.org/TR/css-transforms-1/#transformable-element.

	15 */

	16 display: block;

	17 }

	18 </style>

	19 <div></div>

	20 <script>

	21 if (window.testRunner)

	22 window.testRunner.waitUntilDone();

	23

	24 requestAnimationFrame(function(ts) {
	jbroman 2016/07/11 22:01:26 nit: indentation nit: indentation
	25 document.styleSheets[0].addRule('div::before', 'transform: translateX(20px) ');

	26 requestAnimationFrame(function(ts) {

	27 requestAnimationFrame(function(ts) {

	28 if (window.testRunner)

	29 window.testRunner.notifyDone();

	30 });

	31 });

	32 });

	33 </script>

OLD	NEW