Add hard stop count

Add hard stop count

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141733002

Committed: https://skia.googlesource.com/skia/+/7f2c85e66bc45ef5fc204e301ed726491160a615

[fmenozzi, 2016-07-11 20:08:12]

Description was changed from

==========
Add hard stop count

BUG=skia:
==========

to

==========
Add hard stop count

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141733002
==========

[fmenozzi, 2016-07-11 20:08:56]

fmenozzi@google.com changed reviewers:
+ tomhudson@google.com

[fmenozzi, 2016-07-11 20:08:57]

Script now reports integer count instead of boolean value for hard stops

ptal

[reed1, 2016-07-11 20:22:55]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-07-11 20:22:55]

hmmm, can we just return a complete set of stops? That seems more generally
useful than one or more specialty fields, and the caller can always easily
compute things like number of equal values, etc.

[fmenozzi, 2016-07-11 20:33:08]

On 2016/07/11 20:22:55, reed1 wrote:
> hmmm, can we just return a complete set of stops? That seems more generally
> useful than one or more specialty fields, and the caller can always easily
> compute things like number of equal values, etc.

I suppose I could, but I don't know how much easier it would actually end up
being for use in determining hard stops. It's a lot easier in SQL to do
something like "WHERE HardStopCount >= 1" than trying to parse the string of
stops (since SQLite doesn't support array types) to find equal values. And since
the actual distribution of hard stops doesn't matter (current algorithm only
needs to know whether they exist at all, and an alternative algorithm I'd like
to try only needs to know the number of hard stops) I question how much actual
value that would provide. The only thing I can think of is if I wanted to try
and visualize stop distributions in the corpus, but I'm not sure whether that's
strictly necessary for now.

[reed1, 2016-07-11 20:37:50]

you don't have to dump the stops, just suggesting we simplify the lua bindings
to be more fundamental, and you can perform counting *before* you dump in your
lua script. I think we can remove both of the specialty fields with this
approach: containsHardStops and isEvenlySpaced

[fmenozzi, 2016-07-12 13:46:28]

Simplified C++-Lua interface, ptal

[fmenozzi, 2016-07-12 15:07:42]

Removed unnecessary code from SkLua.cpp, ptal

[tomhudson, 2016-07-12 15:12:08]

LGTM modulo nit

https://codereview.chromium.org/2141733002/diff/40001/tools/lua/gradients.py
File tools/lua/gradients.py (right):

https://codereview.chromium.org/2141733002/diff/40001/tools/lua/gradients.py#...
tools/lua/gradients.py:3: # Copyright 2016 Google Inc.
Nit: I think we aren't supposed to update these dates?

[fmenozzi, 2016-07-12 15:15:23]

https://codereview.chromium.org/2141733002/diff/40001/tools/lua/gradients.py
File tools/lua/gradients.py (right):

https://codereview.chromium.org/2141733002/diff/40001/tools/lua/gradients.py#...
tools/lua/gradients.py:3: # Copyright 2016 Google Inc.
On 2016/07/12 15:12:08, tomhudson wrote:
> Nit: I think we aren't supposed to update these dates?

I added this file with the original Lua scripting commit and I must have
accidentally put the wrong date. It should be 2016.

[fmenozzi, 2016-07-12 15:21:57]

The CQ bit was checked by fmenozzi@google.com

[commit-bot: I haz the power, 2016-07-12 15:22:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-12 15:44:46]

lgtm w/ naming nit on lua file

https://codereview.chromium.org/2141733002/diff/40001/tools/lua/gradients.lua
File tools/lua/gradients.lua (right):

https://codereview.chromium.org/2141733002/diff/40001/tools/lua/gradients.lua...
tools/lua/gradients.lua:4: SkScalarNearlyZero = 1.0 / bit32.lshift(1.0, 12)
since lua just has doubles, I don't think it helps to call this SkScalar

[commit-bot: I haz the power, 2016-07-12 16:17:41]

Description was changed from

==========
Add hard stop count

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141733002
==========

to

==========
Add hard stop count

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141733002

Committed:
https://skia.googlesource.com/skia/+/7f2c85e66bc45ef5fc204e301ed726491160a615
==========

[commit-bot: I haz the power, 2016-07-12 16:17:42]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7f2c85e66bc45ef5fc204e301ed726491160a615

[commit-bot: I haz the power, 2016-07-12 16:17:45]

CQ bit was unchecked.