Send TextEvent message from Android client

Send TextEvent message from Android client

The new message is currently used only for keys for which Android
generates ACTION_MULTIPLE events.

BUG=265945, 270356
R=lambroslambrou@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260088

[Lambros, 2014-03-27 04:20:40]

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:129: public
boolean dispatchKeyEvent(KeyEvent event) {
I don't understand why you've removed the handlers for KEYCODE_AT and so on?
Does your new code correctly deal with those cases?

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:138: // send
KeyEvents in case when any of the modifiers keys is pressed.
remove "when", s/is/are

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:139: switch
(event.getAction()) {
Please add a default case. Findbugs will complain if you don't :)
To run findbugs: build/android/findbugs_diff.py
and check there are no new errors.

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:309:
boolean buttonDown);
I think continuation lines are meant to be 8-space indented? Don't know if
Android Java style allows lining up with open paren?

[Lambros, 2014-03-27 15:41:52]

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:138: // send
KeyEvents in case when any of the modifiers keys is pressed.
On 2014/03/27 04:20:40, Lambros wrote:
> remove "when", s/is/are
On second thoughts, maybe this:
... in the case when any of the modifier keys are pressed.

[Sergey Ulanov, 2014-03-28 00:09:46]

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:129: public
boolean dispatchKeyEvent(KeyEvent event) {
On 2014/03/27 04:20:40, Lambros wrote:
> I don't understand why you've removed the handlers for KEYCODE_AT and so on?
> Does your new code correctly deal with those cases?

I was testing with the Google keyboard and it already generates proper sequences
for these keys. But now I realize that other keyboard may work differently
(hackers keyboard seems to be an example). Restored the old code here.

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:138: // send
KeyEvents in case when any of the modifiers keys is pressed.
On 2014/03/27 15:41:53, Lambros wrote:
> On 2014/03/27 04:20:40, Lambros wrote:
> > remove "when", s/is/are
> On second thoughts, maybe this:
> ... in the case when any of the modifier keys are pressed.
> 

Done.

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:138: // send
KeyEvents in case when any of the modifiers keys is pressed.
On 2014/03/27 04:20:40, Lambros wrote:
> remove "when", s/is/are

Done.

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:139: switch
(event.getAction()) {
On 2014/03/27 04:20:40, Lambros wrote:
> Please add a default case. Findbugs will complain if you don't :)
> To run findbugs: build/android/findbugs_diff.py
> and check there are no new errors.

Done.

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/214173002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:309:
boolean buttonDown);
On 2014/03/27 04:20:40, Lambros wrote:
> I think continuation lines are meant to be 8-space indented? Don't know if
> Android Java style allows lining up with open paren?

Done. Also updated nativeAuthenticationResponse() above

[Lambros, 2014-03-28 00:42:27]

lgtm

[Sergey Ulanov, 2014-03-28 00:42:53]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-28 00:46:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/214173002/60001

[commit-bot: I haz the power, 2014-03-28 01:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:49:54]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Sergey Ulanov, 2014-03-28 02:39:43]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:41:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/214173002/80001

[commit-bot: I haz the power, 2014-03-28 03:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:14:21]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Lambros, 2014-03-28 03:35:30]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:36:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/214173002/80001

[commit-bot: I haz the power, 2014-03-28 04:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 04:33:29]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Sergey Ulanov, 2014-03-28 07:50:26]

Committed patchset #4 manually as r260088 (presubmit successful).