Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2141723005: Delete eased-keyframes (Closed)

Created:
4 years, 5 months ago by dstockwell
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete eased-keyframes This test is redundant with existing tests in the W3C web-platform-tests. BUG=623437 Committed: https://crrev.com/6dd82328b035d34e3ac61bdffa4e3a6b7a8d5681 Cr-Commit-Position: refs/heads/master@{#405082}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -204 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 1 comment Download
D third_party/WebKit/LayoutTests/web-animations-api/eased-keyframes.html View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/eased-keyframes.html View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dstockwell
4 years, 5 months ago (2016-07-12 01:57:16 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm https://codereview.chromium.org/2141723005/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2141723005/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode823 third_party/WebKit/LayoutTests/TestExpectations:823: # We only want to run one of ...
4 years, 5 months ago (2016-07-12 02:06:49 UTC) #3
alancutter (OOO until 2018)
Mention in the description why we can remove this test.
4 years, 5 months ago (2016-07-12 03:57:18 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-13 07:27:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141723005/1
4 years, 5 months ago (2016-07-13 07:28:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:36:09 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:37:32 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6dd82328b035d34e3ac61bdffa4e3a6b7a8d5681
Cr-Commit-Position: refs/heads/master@{#405082}

Powered by Google App Engine
This is Rietveld 408576698