Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2141723003: PPC/s390: [builtins] Construct builtin frame in String/Number ctors (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Construct builtin frame in String/Number ctors Port d49d3864d7854ac485884bd60312bc3246edc476 R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5173 LOG=N Committed: https://crrev.com/0ac774095f304d23a6d3553dfca6d1c0eaa96017 Cr-Commit-Position: refs/heads/master@{#37659}

Patch Set 1 #

Patch Set 2 : fixed Load instr, don't have to update sp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -105 lines) Patch
M src/ppc/builtins-ppc.cc View 1 12 chunks +96 lines, -53 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 11 chunks +97 lines, -52 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
john.yan
lgtm
4 years, 5 months ago (2016-07-11 20:21:13 UTC) #1
JaideepBajwa
PTAL. Fixed the load instruction where sp shouldn't be updated. Also fixed register mapping error ...
4 years, 5 months ago (2016-07-11 21:37:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141723003/20001
4 years, 5 months ago (2016-07-11 21:39:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 22:00:52 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 22:04:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ac774095f304d23a6d3553dfca6d1c0eaa96017
Cr-Commit-Position: refs/heads/master@{#37659}

Powered by Google App Engine
This is Rietveld 408576698