Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 2141713003: Clean up non-animatable-property.html test to match W3C (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed non-animatable-property.html test to match W3C Removed web-animations-api/non-animatable-property.html test since it is a duplicate of interfaces/KeyframeEffect/processing-a-keyframes-argument.html. Part of the web animations test burndown. BUG=623437 Committed: https://crrev.com/23acb16dc5e79086933eb124485433d4ad0d234e Cr-Commit-Position: refs/heads/master@{#404788}

Patch Set 1 #

Patch Set 2 : Removed global variable #

Patch Set 3 : Removed dupe test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/non-animatable-property.html View 1 2 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sashab
4 years, 5 months ago (2016-07-12 01:08:30 UTC) #2
alancutter (OOO until 2018)
I think this is a dupe of interfaces/KeyframeEffect/processing-a-keyframes-argument.html.
4 years, 5 months ago (2016-07-12 03:31:17 UTC) #3
sashab
4 years, 5 months ago (2016-07-12 03:46:02 UTC) #5
sashab
4 years, 5 months ago (2016-07-12 03:48:57 UTC) #6
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-12 04:29:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141713003/40001
4 years, 5 months ago (2016-07-12 04:33:19 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-12 06:12:15 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 06:12:33 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 06:15:19 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/23acb16dc5e79086933eb124485433d4ad0d234e
Cr-Commit-Position: refs/heads/master@{#404788}

Powered by Google App Engine
This is Rietveld 408576698