Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2141703004: Clean up web-animations-api/deferred-updates.html test to match webkit (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed web-animations-api/deferred-updates.html test Removed web-animations-api/deferred-updates.html test, since its not adding testing coverage/value. BUG=623437 Committed: https://crrev.com/00fe80aa4a431a9aff84b52ec17d9de672cd87c5 Cr-Commit-Position: refs/heads/master@{#404793}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/deferred-updates.html View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sashab
4 years, 5 months ago (2016-07-12 00:20:04 UTC) #2
alancutter (OOO until 2018)
We intend to upstream this to w3c/web-platform-tests rather than WebKit. I don't think there's much ...
4 years, 5 months ago (2016-07-12 00:51:58 UTC) #3
sashab
4 years, 5 months ago (2016-07-12 03:46:59 UTC) #5
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-12 04:30:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141703004/20001
4 years, 5 months ago (2016-07-12 04:33:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 07:27:40 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 07:27:51 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 07:29:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00fe80aa4a431a9aff84b52ec17d9de672cd87c5
Cr-Commit-Position: refs/heads/master@{#404793}

Powered by Google App Engine
This is Rietveld 408576698