Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2141673002: [DevTools] Always send a copy of worker message through the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameConsole.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameConsole.cpp b/third_party/WebKit/Source/core/frame/FrameConsole.cpp
index 99f33fe8afccc34dc1869563b0190cd341f7243e..a27fb0c88399ad7433c0e32a4ca9ddca3074d9e1 100644
--- a/third_party/WebKit/Source/core/frame/FrameConsole.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameConsole.cpp
@@ -69,7 +69,8 @@ bool FrameConsole::addMessageToStorage(ConsoleMessage* consoleMessage)
consoleMessage->location()->columnNumber(),
consoleMessage->location()->cloneStackTrace(),
consoleMessage->location()->scriptId(),
- IdentifiersFactory::requestId(consoleMessage->requestIdentifier()));
+ IdentifiersFactory::requestId(consoleMessage->requestIdentifier()),
+ consoleMessage->workerId());
}
void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)
@@ -95,14 +96,10 @@ void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)
frame().chromeClient().addMessageToConsole(m_frame, consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), consoleMessage->location()->lineNumber(), url, stackTrace);
}
-void FrameConsole::reportWorkerMessage(ConsoleMessage* consoleMessage)
+void FrameConsole::addMessageFromWorker(ConsoleMessage* consoleMessage, const String& workerId)
{
reportMessageToClient(consoleMessage);
-}
-
-void FrameConsole::adoptWorkerMessage(ConsoleMessage* consoleMessage)
-{
- addMessageToStorage(consoleMessage);
+ addMessageToStorage(ConsoleMessage::createFromWorker(consoleMessage->level(), consoleMessage->message(), consoleMessage->location() ? consoleMessage->location()->clone() : nullptr, workerId));
}
void FrameConsole::reportResourceResponseReceived(DocumentLoader* loader, unsigned long requestIdentifier, const ResourceResponse& response)
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameConsole.h ('k') | third_party/WebKit/Source/core/inspector/ConsoleMessage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698