Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameConsole.h

Issue 2141673002: [DevTools] Always send a copy of worker message through the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: new approach Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector. 44 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
45 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console. 45 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
46 class CORE_EXPORT FrameConsole final : public GarbageCollected<FrameConsole> { 46 class CORE_EXPORT FrameConsole final : public GarbageCollected<FrameConsole> {
47 public: 47 public:
48 static FrameConsole* create(LocalFrame& frame) 48 static FrameConsole* create(LocalFrame& frame)
49 { 49 {
50 return new FrameConsole(frame); 50 return new FrameConsole(frame);
51 } 51 }
52 52
53 void addMessage(ConsoleMessage*); 53 void addMessage(ConsoleMessage*);
54 void addWorkerMessage(ConsoleMessage*, const String& workerId);
pfeldman 2016/07/11 21:37:27 addMessageFromWorker
dgozman 2016/07/12 01:16:38 Done.
55
54 bool addMessageToStorage(ConsoleMessage*); 56 bool addMessageToStorage(ConsoleMessage*);
55 void reportMessageToClient(ConsoleMessage*); 57 void reportMessageToClient(ConsoleMessage*);
56 58
57 void reportWorkerMessage(ConsoleMessage*);
58 void adoptWorkerMessage(ConsoleMessage*);
59
60 void reportResourceResponseReceived(DocumentLoader*, unsigned long requestId entifier, const ResourceResponse&); 59 void reportResourceResponseReceived(DocumentLoader*, unsigned long requestId entifier, const ResourceResponse&);
61 60
62 void clearMessages(); 61 void clearMessages();
63 62
64 void didFailLoading(unsigned long requestIdentifier, const ResourceError&); 63 void didFailLoading(unsigned long requestIdentifier, const ResourceError&);
65 64
66 DECLARE_TRACE(); 65 DECLARE_TRACE();
67 66
68 private: 67 private:
69 explicit FrameConsole(LocalFrame&); 68 explicit FrameConsole(LocalFrame&);
70 69
71 LocalFrame& frame() const 70 LocalFrame& frame() const
72 { 71 {
73 ASSERT(m_frame); 72 ASSERT(m_frame);
74 return *m_frame; 73 return *m_frame;
75 } 74 }
76 75
77 Member<LocalFrame> m_frame; 76 Member<LocalFrame> m_frame;
78 }; 77 };
79 78
80 } // namespace blink 79 } // namespace blink
81 80
82 #endif // FrameConsole_h 81 #endif // FrameConsole_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698