Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2141663002: [Cronet] Check whether request is done before spinning up message loop (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Cronet] Check whether request is done before spinning up message loop When client writes to OutputStream, the request might have already completed. If that is the case, do not spin up the message loop since that will block the calling thread forever. This CL also adds tests. TBR=mef@chromium.org BUG=626653 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2131323002 Cr-Commit-Position: refs/heads/master@{#404652} (cherry picked from commit b08d71cee8ab485bc4bf6872d01be9fe8b4df296)

Patch Set 1 #

Messages

Total messages: 7 (1 generated)
xunjieli
Hi Misha, this is to merge the change into M53. I will verify locally that ...
4 years, 5 months ago (2016-07-11 17:45:16 UTC) #1
mef
lgtm
4 years, 5 months ago (2016-07-11 17:49:38 UTC) #2
xunjieli
On 2016/07/11 17:49:38, mef wrote: > lgtm Thanks! I verified locally that Cronet tests are ...
4 years, 5 months ago (2016-07-11 18:40:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141663002/1
4 years, 5 months ago (2016-07-11 18:41:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 18:43:13 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 18:43:18 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698