Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h

Issue 214163002: Added separate required, optional and file permissions to app info dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attempted tsan fix and some leak fixes Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
index e60ba09b1855ee7b44ea7e0846d3a95a9e7e8428..3fb042b9363b6c2b6854c87b8c044c6b9ea71feb 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
@@ -12,6 +12,10 @@ class Profile;
namespace extensions {
class Extension;
+class PermissionSet;
+}
+namespace views {
+class ScrollView;
}
// The Permissions tab of the app info dialog, which provides insight and
@@ -25,6 +29,30 @@ class AppInfoPermissionsTab : public AppInfoTab {
virtual ~AppInfoPermissionsTab();
+ private:
+ FRIEND_TEST_ALL_PREFIXES(AppInfoPermissionsTabTest,
+ NoPermissionsObtainedCorrectly);
+ FRIEND_TEST_ALL_PREFIXES(AppInfoPermissionsTabTest,
+ RequiredPermissionsObtainedCorrectly);
+ FRIEND_TEST_ALL_PREFIXES(AppInfoPermissionsTabTest,
+ OptionalPermissionsObtainedCorrectly);
+ FRIEND_TEST_ALL_PREFIXES(AppInfoPermissionsTabTest,
+ RetainedFilePermissionsObtainedCorrectly);
+
+ // Overridden from views::View:
+ virtual void Layout() OVERRIDE;
+
+ const extensions::PermissionSet* GetRequiredPermissions() const;
+ const std::vector<base::string16> GetRequiredPermissionMessages() const;
+
+ const extensions::PermissionSet* GetOptionalPermissions() const;
+ const std::vector<base::string16> GetOptionalPermissionMessages() const;
+
+ const std::vector<base::FilePath> GetRetainedFilePermissions() const;
+ const std::vector<base::string16> GetRetainedFilePermissionMessages() const;
+
+ views::ScrollView* scroll_view_;
+
DISALLOW_COPY_AND_ASSIGN(AppInfoPermissionsTab);
};
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698