Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2141603002: Make toLocaleString on arrays always call toLocaleString on its elements. (Closed)

Created:
4 years, 5 months ago by neis
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make toLocaleString on arrays always call toLocaleString on its elements. As required by the spec. BUG=v8:5113 Committed: https://crrev.com/457c02573cc25ce548a88457cc6e23ef73a637a1 Cr-Commit-Position: refs/heads/master@{#37689}

Patch Set 1 #

Patch Set 2 : Simplify. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M src/js/array.js View 1 2 chunks +5 lines, -23 lines 0 comments Download
M test/mjsunit/array-tostring.js View 2 chunks +23 lines, -1 line 0 comments Download
M test/mjsunit/es6/typedarray-tostring.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
neis
PTAL I run some benchmarks to see if this negatively impacts performance but couldn't really ...
4 years, 5 months ago (2016-07-12 08:24:23 UTC) #12
Dan Ehrenberg
On 2016/07/12 08:24:23, neis wrote: > PTAL > > I run some benchmarks to see ...
4 years, 5 months ago (2016-07-12 16:26:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141603002/60001
4 years, 5 months ago (2016-07-12 17:06:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 5 months ago (2016-07-12 17:32:38 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 17:33:47 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/457c02573cc25ce548a88457cc6e23ef73a637a1
Cr-Commit-Position: refs/heads/master@{#37689}

Powered by Google App Engine
This is Rietveld 408576698