Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2141573004: Monitor profile tool, now with Windows support, too! (Closed)

Created:
4 years, 5 months ago by Brian Osman
Modified:
4 years, 5 months ago
Reviewers:
msarett, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Monitor profile tool, now with Windows support, too! Original Mac support by Matt. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095093002 Committed: https://skia.googlesource.com/skia/+/6373c955541f6ebbb075ee6b2a58daa22ea9cecf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback, fix compile error on other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M gyp/tools.gyp View 2 chunks +16 lines, -0 lines 0 comments Download
A tools/get_current_monitor_profile.cpp View 1 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Brian Osman
4 years, 5 months ago (2016-07-12 18:50:01 UTC) #2
msarett
https://codereview.chromium.org/2141573004/diff/1/tools/get_current_monitor_profile.cpp File tools/get_current_monitor_profile.cpp (right): https://codereview.chromium.org/2141573004/diff/1/tools/get_current_monitor_profile.cpp#newcode23 tools/get_current_monitor_profile.cpp:23: SkFILEWStream file("monitor.icc"); Maybe make this monitor_0.icc for consistency? https://codereview.chromium.org/2141573004/diff/1/tools/get_current_monitor_profile.cpp#newcode33 ...
4 years, 5 months ago (2016-07-12 18:56:50 UTC) #7
msarett
FWIW, both Mac profiles I've looked at so far have been sRGB gamma, arbitrary gamut. ...
4 years, 5 months ago (2016-07-12 18:58:36 UTC) #8
Brian Osman
Fixed compile error in unsupported platform code, addressed Matt's feedback.
4 years, 5 months ago (2016-07-12 19:04:19 UTC) #11
msarett
lgtm
4 years, 5 months ago (2016-07-12 19:05:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141573004/20001
4 years, 5 months ago (2016-07-12 19:27:53 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6373c955541f6ebbb075ee6b2a58daa22ea9cecf
4 years, 5 months ago (2016-07-12 22:06:30 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:06:32 UTC) #19
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698