Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2141573002: Deflake image-zoom-to-{25,500}.html (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
haraken, carlosk
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake image-zoom-to-{25,500}.html Before finishing the test, remove the resize event listener, as we just resized, and the window is about to be closed. Otherwise, we might get spurious output from the event listener running in a detached context BUG=627030 R=haraken@chromium.org,carlosk@chromium.org Committed: https://crrev.com/74a3e66f56274c9d970e9c20aef86df3da7e73d1 Cr-Commit-Position: refs/heads/master@{#404638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/images/image-zoom-to-25.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/image-zoom-to-500.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-11 11:26:38 UTC) #1
haraken
LGTM
4 years, 5 months ago (2016-07-11 11:35:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141573002/1
4 years, 5 months ago (2016-07-11 11:37:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 12:32:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 12:34:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74a3e66f56274c9d970e9c20aef86df3da7e73d1
Cr-Commit-Position: refs/heads/master@{#404638}

Powered by Google App Engine
This is Rietveld 408576698