Issue 214153006: Oilpan: move ImageData to the oilpan heap.

Issue 214153006: Oilpan: move ImageData to the oilpan heap. (Closed)

Created:
6 years, 8 months ago by sof

Modified:
6 years, 8 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, aandrey+blink_chromium.org, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: move ImageData to the oilpan heap. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170445

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ImageData 'explicit' #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -30 lines)			Patch
M	Source/bindings/v8/SerializedScriptValue.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLCanvasElement.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLCanvasElement.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/ImageData.h	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download
M	Source/core/html/ImageData.cpp	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/html/ImageData.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContextBase.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContextBase.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. (Have modified ImageData in other ways recently, so thought I'd do ...

6 years, 8 months ago (2014-03-31 12:49:48 UTC) #1

haraken

LGTM https://codereview.chromium.org/214153006/diff/1/Source/core/html/ImageData.h File Source/core/html/ImageData.h (right): https://codereview.chromium.org/214153006/diff/1/Source/core/html/ImageData.h#newcode58 Source/core/html/ImageData.h:58: ImageData(const IntSize&); Add explicit.

6 years, 8 months ago (2014-03-31 12:51:58 UTC) #2

sof

https://codereview.chromium.org/214153006/diff/1/Source/core/html/ImageData.h File Source/core/html/ImageData.h (right): https://codereview.chromium.org/214153006/diff/1/Source/core/html/ImageData.h#newcode58 Source/core/html/ImageData.h:58: ImageData(const IntSize&); On 2014/03/31 12:51:59, haraken wrote: > > ...

6 years, 8 months ago (2014-03-31 13:02:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/214153006/20001

6 years, 8 months ago (2014-03-31 13:02:33 UTC) #5

Message was sent while issue was closed.

Change committed as 170445

Expand Messages | Collapse Messages