Issue 214153005: Fix typo in MockSpellCheck::misspelledWords

Issue 214153005: Fix typo in MockSpellCheck::misspelledWords (Closed)

Created:
6 years, 8 months ago by grzegorz

Modified:
6 years, 8 months ago

Reviewers:
tony, groby-ooo-7-16, Dirk Pranke, Tommy Widenflycht, abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix typo in MockSpellCheck::misspelledWords Replace 'asd' into 'asdf' since editing/spelling/design-mode-spellcheck-off.html is using it. The test was always passing as it expects not to have spelling markers due to <body spellcheck=false> BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260835

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/shell/renderer/test_runner/MockSpellCheck.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/214153005/1

6 years, 8 months ago (2014-04-01 07:01:45 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-01 07:44:12 UTC) #5

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58755

6 years, 8 months ago (2014-04-01 07:44:13 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/214153005/1

6 years, 8 months ago (2014-04-01 08:41:26 UTC) #10

pfeldman

A revert of this CL has been created in https://codereview.chromium.org/221763002/ by pfeldman@chromium.org. The reason for ...

6 years, 8 months ago (2014-04-02 04:08:25 UTC) #12

grzegorz

6 years, 8 months ago (2014-04-07 07:25:31 UTC) #13

Message was sent while issue was closed.

On 2014/04/02 04:08:25, pfeldman wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/221763002/ by mailto:pfeldman@chromium.org.
> 
> The reason for reverting is: Breaks test upstream:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....

I was unaware that editing/selection/13804.html had verified spelling. The
tendency is to keep them under editing/spelling directory (done at
https://codereview.chromium.org/225183005/).

Consistent with editing/selection/13804.html which is using 'asd' as misspelled
word, design-mode-spellcheck-off.html uses is as well
https://codereview.chromium.org/219073002/. As a result, the typo fix is no
longer needed.

Expand Messages | Collapse Messages