Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 214153002: Add clip effect for circles (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add clip effect for circles BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13974

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -6 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/effects/GrOvalEffect.h View 1 chunk +24 lines, -0 lines 0 comments Download
A src/gpu/effects/GrOvalEffect.cpp View 1 2 1 chunk +193 lines, -0 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
I think the try bot failures are all related to the nvpr text context and ...
6 years, 9 months ago (2014-03-27 17:05:10 UTC) #1
jvanverth1
LGTM. It seems like you should be able to infer the center of the circle ...
6 years, 9 months ago (2014-03-27 20:05:49 UTC) #2
bsalomon
On 2014/03/27 20:05:49, JimVV wrote: > LGTM. It seems like you should be able to ...
6 years, 9 months ago (2014-03-27 20:09:33 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-28 14:37:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/214153002/40001
6 years, 9 months ago (2014-03-28 14:37:16 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 15:58:51 UTC) #6
Message was sent while issue was closed.
Change committed as 13974

Powered by Google App Engine
This is Rietveld 408576698