Issue 2141503005: Fix language/vm/optimized_stacktrace_test reload crash

Issue 2141503005: Fix language/vm/optimized_stacktrace_test reload crash (Closed)

Created:
4 years, 5 months ago by Cutch

Modified:
4 years, 5 months ago

Reviewers:
Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix language/vm/optimized_stacktrace_test reload crash Fixes crash: runtime/vm/object.h: 4787: error: expected: raw() != null() (gdb) bt #0 0x00007ffff6c01c37 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x00007ffff6c05028 in __GI_abort () at abort.c:89 #2 0x000000000084b879 in dart::OS::Abort () at runtime/vm/os_linux.cc:424 #3 0x00000000005c0585 in dart::DynamicAssertionHelper::Fail (this=this@entry=0x7ffff5776390, format=format@entry=0xb9f864 "expected: %s") at runtime/platform/assert.cc:46 #4 0x000000000062e68b in dart::Code::raw_ptr (this=0x7fffe8181ad0) at runtime/vm/object.h:4787 #5 0x00000000007ce875 in var_descriptors (this=this@entry=0x7fffe8181ad0) at runtime/vm/object.h:4593 #6 dart::Code::GetLocalVarDescriptors (this=this@entry=0x7fffe8181ad0) at runtime/vm/object.cc:13582 #7 0x000000000066159a in dart::ActivationFrame::GetVarDescriptors (this=0x7ffff5776980) at runtime/vm/debugger.cc:580 #8 0x0000000000665ed5 in GetVarDescriptors (this=0x7ffff5776980) at runtime/vm/debugger.cc:788 #9 dart::ActivationFrame::GetDescIndices (this=this@entry=0x7ffff5776980) at runtime/vm/debugger.cc:719 #10 0x0000000000666121 in dart::ActivationFrame::NumLocalVariables (this=this@entry=0x7ffff5776980) at runtime/vm/debugger.cc:792 #11 0x0000000000629a00 in DRT_HelperStackOverflow (zone=<optimized out>, thread=0x12bf680, isolate=<optimized out>, arguments=...) at runtime/vm/code_generator.cc:1324 #12 dart::DRT_StackOverflow (arguments=...) at runtime/vm/code_generator.cc:1217 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/112bf612e5b78c234bbbeedba3f9b40e9a048f8e

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/code_generator.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Description was changed from ========== Fix language/vm/optimized_stacktrace_test reload crash BUG= ========== to ========== Fix language/vm/optimized_stacktrace_test ...

4 years, 5 months ago (2016-07-12 14:23:17 UTC) #3

Cutch

Description was changed from ========== Fix language/vm/optimized_stacktrace_test reload crash Fixes crash: runtime/vm/object.h: 4787: error: expected: ...

4 years, 5 months ago (2016-07-12 17:43:36 UTC) #6

Description was changed from

==========
Fix language/vm/optimized_stacktrace_test reload crash


Fixes crash:

runtime/vm/object.h: 4787: error: expected: raw() != null()
(gdb) bt
#0  0x00007ffff6c01c37 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007ffff6c05028 in __GI_abort () at abort.c:89
#2  0x000000000084b879 in dart::OS::Abort () at runtime/vm/os_linux.cc:424
#3  0x00000000005c0585 in dart::DynamicAssertionHelper::Fail
(this=this@entry=0x7ffff5776390, 
    format=format@entry=0xb9f864 "expected: %s") at
runtime/platform/assert.cc:46
#4  0x000000000062e68b in dart::Code::raw_ptr (this=0x7fffe8181ad0) at
runtime/vm/object.h:4787
#5  0x00000000007ce875 in var_descriptors (this=this@entry=0x7fffe8181ad0) at
runtime/vm/object.h:4593
#6  dart::Code::GetLocalVarDescriptors (this=this@entry=0x7fffe8181ad0) at
runtime/vm/object.cc:13582
#7  0x000000000066159a in dart::ActivationFrame::GetVarDescriptors
(this=0x7ffff5776980) at runtime/vm/debugger.cc:580
#8  0x0000000000665ed5 in GetVarDescriptors (this=0x7ffff5776980) at
runtime/vm/debugger.cc:788
#9  dart::ActivationFrame::GetDescIndices (this=this@entry=0x7ffff5776980) at
runtime/vm/debugger.cc:719
#10 0x0000000000666121 in dart::ActivationFrame::NumLocalVariables
(this=this@entry=0x7ffff5776980) at runtime/vm/debugger.cc:792
#11 0x0000000000629a00 in DRT_HelperStackOverflow (zone=<optimized out>,
thread=0x12bf680, isolate=<optimized out>, arguments=...)
    at runtime/vm/code_generator.cc:1324
#12 dart::DRT_StackOverflow (arguments=...) at runtime/vm/code_generator.cc:1217
==========

to

==========
Fix language/vm/optimized_stacktrace_test reload crash


Fixes crash:

runtime/vm/object.h: 4787: error: expected: raw() != null()
(gdb) bt
#0  0x00007ffff6c01c37 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007ffff6c05028 in __GI_abort () at abort.c:89
#2  0x000000000084b879 in dart::OS::Abort () at runtime/vm/os_linux.cc:424
#3  0x00000000005c0585 in dart::DynamicAssertionHelper::Fail
(this=this@entry=0x7ffff5776390,
    format=format@entry=0xb9f864 "expected: %s") at
runtime/platform/assert.cc:46
#4  0x000000000062e68b in dart::Code::raw_ptr (this=0x7fffe8181ad0) at
runtime/vm/object.h:4787
#5  0x00000000007ce875 in var_descriptors (this=this@entry=0x7fffe8181ad0) at
runtime/vm/object.h:4593
#6  dart::Code::GetLocalVarDescriptors (this=this@entry=0x7fffe8181ad0) at
runtime/vm/object.cc:13582
#7  0x000000000066159a in dart::ActivationFrame::GetVarDescriptors
(this=0x7ffff5776980) at runtime/vm/debugger.cc:580
#8  0x0000000000665ed5 in GetVarDescriptors (this=0x7ffff5776980) at
runtime/vm/debugger.cc:788
#9  dart::ActivationFrame::GetDescIndices (this=this@entry=0x7ffff5776980) at
runtime/vm/debugger.cc:719
#10 0x0000000000666121 in dart::ActivationFrame::NumLocalVariables
(this=this@entry=0x7ffff5776980) at runtime/vm/debugger.cc:792
#11 0x0000000000629a00 in DRT_HelperStackOverflow (zone=<optimized out>,
thread=0x12bf680, isolate=<optimized out>, arguments=...)
    at runtime/vm/code_generator.cc:1324
#12 dart::DRT_StackOverflow (arguments=...) at runtime/vm/code_generator.cc:1217

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/112bf612e5b78c234bbbeedba3f9b40e9a048f8e
==========

Cutch

Committed patchset #1 (id:1) manually as 112bf612e5b78c234bbbeedba3f9b40e9a048f8e (presubmit successful).

4 years, 5 months ago (2016-07-12 17:43:38 UTC) #7

Message was sent while issue was closed.

This test started failing on the precompilation bots.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages