Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2141483002: SELECT element: Simplify the code by optionList(). (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, eae+blinkwatch, haraken, jchaffraix+rendering, je_julie, kinuko+watch, leviw+renderwatch, nektarios, nektar+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Simplify the code by optionList(). Using optinList() instead of listItems() simplifies the code. This CL should not have any behavior changes. Committed: https://crrev.com/88867812c615e2f89551aff6b583c9f8f3a37e1c Cr-Commit-Position: refs/heads/master@{#404603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -77 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 7 chunks +25 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 2 chunks +7 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSearchableFormData.cpp View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-11 06:01:49 UTC) #2
keishi
LGTM
4 years, 5 months ago (2016-07-11 06:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141483002/1
4 years, 5 months ago (2016-07-11 06:11:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 06:15:24 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 06:15:28 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 06:17:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88867812c615e2f89551aff6b583c9f8f3a37e1c
Cr-Commit-Position: refs/heads/master@{#404603}

Powered by Google App Engine
This is Rietveld 408576698