Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/tests/results/V8SVGTestInterface.cpp

Issue 214143003: Bindings: use |holder| local variable in attribute getters and setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8SVGTestInterface.cpp
diff --git a/Source/bindings/tests/results/V8SVGTestInterface.cpp b/Source/bindings/tests/results/V8SVGTestInterface.cpp
index 18b0a8efa4b0944d78f4c23aa29c79cdb83f11e9..59160dc3c1e953f566a5d7bc09df25e6cf0eebad 100644
--- a/Source/bindings/tests/results/V8SVGTestInterface.cpp
+++ b/Source/bindings/tests/results/V8SVGTestInterface.cpp
@@ -46,7 +46,8 @@ template <typename T> void V8_USE(T) { }
static void typeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- SVGTestInterface* impl = V8SVGTestInterface::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ SVGTestInterface* impl = V8SVGTestInterface::toNative(holder);
v8SetReturnValueString(info, impl->fastGetAttribute(SVGNames::typeAttr), info.GetIsolate());
}
@@ -59,7 +60,8 @@ static void typeAttributeGetterCallback(v8::Local<v8::String>, const v8::Propert
static void typeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
- SVGTestInterface* impl = V8SVGTestInterface::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ SVGTestInterface* impl = V8SVGTestInterface::toNative(holder);
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue, jsValue);
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
impl->setAttribute(SVGNames::typeAttr, cppValue);
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698