Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

Issue 214143003: Bindings: use |holder| local variable in attribute getters and setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
index 5a1781eac0f2b193843c30c7987b1af14c2e6a46..94417d137f3047b2319494b3c866475f7430ad3c 100644
--- a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
@@ -51,7 +51,8 @@ template <typename T> void V8_USE(T) { }
static void readonlyStringAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueString(info, impl->readonlyStringAttribute(), info.GetIsolate());
}
@@ -64,7 +65,8 @@ static void readonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String>
static void initializedByEventConstructorReadonlyStringAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueString(info, impl->initializedByEventConstructorReadonlyStringAttribute(), info.GetIsolate());
}
@@ -77,7 +79,8 @@ static void initializedByEventConstructorReadonlyStringAttributeAttributeGetterC
static void initializedByEventConstructorReadonlyAnyAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValue(info, impl->initializedByEventConstructorReadonlyAnyAttribute().v8Value());
}
@@ -90,7 +93,8 @@ static void initializedByEventConstructorReadonlyAnyAttributeAttributeGetterCall
static void initializedByEventConstructorReadonlyBooleanAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueBool(info, impl->initializedByEventConstructorReadonlyBooleanAttribute());
}
@@ -103,7 +107,8 @@ static void initializedByEventConstructorReadonlyBooleanAttributeAttributeGetter
static void initializedByEventConstructorReadonlyLongAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueInt(info, impl->initializedByEventConstructorReadonlyLongAttribute());
}
@@ -116,13 +121,15 @@ static void initializedByEventConstructorReadonlyLongAttributeAttributeGetterCal
static void initializedByEventConstructorReadonlyUint8ArrayAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Isolate* isolate = info.GetIsolate();
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
RefPtr<Uint8Array> result(impl->initializedByEventConstructorReadonlyUint8ArrayAttribute());
if (result && DOMDataStore::setReturnValueFromWrapper<V8Uint8Array>(info.GetReturnValue(), result.get()))
return;
- v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
+ v8::Handle<v8::Value> wrapper = toV8(result.get(), holder, isolate);
if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyUint8ArrayAttribute"), wrapper);
+ V8HiddenValue::setHiddenValue(isolate, holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyUint8ArrayAttribute"), wrapper);
v8SetReturnValue(info, wrapper);
}
}
@@ -136,13 +143,15 @@ static void initializedByEventConstructorReadonlyUint8ArrayAttributeAttributeGet
static void initializedByEventConstructorReadonlyTestInterfaceEmptyAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Isolate* isolate = info.GetIsolate();
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
RefPtr<TestInterfaceEmpty> result(impl->initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute());
if (result && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>(info.GetReturnValue(), result.get()))
return;
- v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
+ v8::Handle<v8::Value> wrapper = toV8(result.get(), holder, isolate);
if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute"), wrapper);
+ V8HiddenValue::setHiddenValue(isolate, holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute"), wrapper);
v8SetReturnValue(info, wrapper);
}
}
@@ -156,7 +165,8 @@ static void initializedByEventConstructorReadonlyTestInterfaceEmptyAttributeAttr
static void initializedByEventConstructorReadonlyTestInterfaceEmptyArrayAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValue(info, v8Array(impl->initializedByEventConstructorReadonlyTestInterfaceEmptyArrayAttribute(), info.GetIsolate()));
}
@@ -169,7 +179,9 @@ static void initializedByEventConstructorReadonlyTestInterfaceEmptyArrayAttribut
static void initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Isolate* isolate = info.GetIsolate();
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
bool isNull = false;
RefPtr<TestInterfaceEmpty> jsValue = impl->initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute(isNull);
if (isNull) {
@@ -179,9 +191,9 @@ static void initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttri
RefPtr<TestInterfaceEmpty> result(jsValue);
if (result && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>(info.GetReturnValue(), result.get()))
return;
- v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
+ v8::Handle<v8::Value> wrapper = toV8(result.get(), holder, isolate);
if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute"), wrapper);
+ V8HiddenValue::setHiddenValue(isolate, holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute"), wrapper);
v8SetReturnValue(info, wrapper);
}
}
@@ -195,7 +207,8 @@ static void initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttri
static void deprecatedInitializedByEventConstructorReadonlyStringAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueString(info, impl->deprecatedInitializedByEventConstructorReadonlyStringAttribute(), info.GetIsolate());
}
@@ -209,7 +222,8 @@ static void deprecatedInitializedByEventConstructorReadonlyStringAttributeAttrib
static void implementedAsInitializedByEventConstructorReadonlyStringAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueString(info, impl->implementedAsName(), info.GetIsolate());
}
@@ -222,7 +236,8 @@ static void implementedAsInitializedByEventConstructorReadonlyStringAttributeAtt
static void deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder);
v8SetReturnValueString(info, impl->deprecatedImplementedAsName(), info.GetIsolate());
}

Powered by Google App Engine
This is Rietveld 408576698