Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: Source/bindings/tests/results/V8TestException.cpp

Issue 214143003: Bindings: use |holder| local variable in attribute getters and setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestException.cpp
diff --git a/Source/bindings/tests/results/V8TestException.cpp b/Source/bindings/tests/results/V8TestException.cpp
index 2873a9baa400ff826fb7e50f7953008231b40130..63e246184e9663a3cc5fd6dc42d85c358d82a398 100644
--- a/Source/bindings/tests/results/V8TestException.cpp
+++ b/Source/bindings/tests/results/V8TestException.cpp
@@ -44,7 +44,8 @@ template <typename T> void V8_USE(T) { }
static void readonlyUnsignedShortAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestException* impl = V8TestException::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestException* impl = V8TestException::toNative(holder);
v8SetReturnValueUnsigned(info, impl->readonlyUnsignedShortAttribute());
}
@@ -57,7 +58,8 @@ static void readonlyUnsignedShortAttributeAttributeGetterCallback(v8::Local<v8::
static void readonlyStringAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestException* impl = V8TestException::toNative(info.Holder());
+ v8::Handle<v8::Object> holder = info.Holder();
+ TestException* impl = V8TestException::toNative(holder);
v8SetReturnValueString(info, impl->readonlyStringAttribute(), info.GetIsolate());
}

Powered by Google App Engine
This is Rietveld 408576698