Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: tools/telemetry/telemetry/page/page_measurement_results.py

Issue 214143002: [telemetry] WebComponents Cleanups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_components/results_viewer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_measurement_results.py
diff --git a/tools/telemetry/telemetry/page/page_measurement_results.py b/tools/telemetry/telemetry/page/page_measurement_results.py
index e97210a16ee955c66f65c9437db76637339c6ba3..16cff29cfda12cd2e85bc58c4c2f8315e0b59af4 100644
--- a/tools/telemetry/telemetry/page/page_measurement_results.py
+++ b/tools/telemetry/telemetry/page/page_measurement_results.py
@@ -52,9 +52,13 @@ class PageMeasurementResults(page_test_results.PageTestResults):
self._page_specific_values_for_current_page = []
def Add(self, trace_name, units, value, chart_name=None, data_type='default'):
+ # TODO(isherman): Remove this as well.
value = value_backcompat.ConvertOldCallingConventionToValue(
self._current_page,
trace_name, units, value, chart_name, data_type)
+ self.AddValue(value)
+
+ def AddValue(self, value):
self._ValidateValue(value)
self._page_specific_values_for_current_page.append(value)
self._all_page_specific_values.append(value)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_components/results_viewer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698