Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 214143002: [telemetry] WebComponents Cleanups (Closed)

Created:
6 years, 9 months ago by nduca
Modified:
6 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] WebComponents Cleanups This is a set of minor cleanups in preparation for adding values that are web components to telemetry.values. - Viewer->WebComponent because we'll have telemetry.values.web_component_value - Let WebComponent data_to_view be mutable - Allow module dependencies of a WebComponent be computed by the subclass, in case it does data-dependent class loading [which they will need to do]. R=dtu BUG=340096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -209 lines) Patch
M tools/telemetry/telemetry/page/page_measurement_results.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_components/results_viewer.py View 1 chunk +6 lines, -11 lines 0 comments Download
D tools/telemetry/telemetry/web_components/viewer.py View 1 chunk +0 lines, -108 lines 0 comments Download
D tools/telemetry/telemetry/web_components/viewer_bootstrap.js View 1 chunk +0 lines, -18 lines 0 comments Download
D tools/telemetry/telemetry/web_components/viewer_unittest.py View 1 chunk +0 lines, -36 lines 0 comments Download
A + tools/telemetry/telemetry/web_components/web_component.py View 5 chunks +40 lines, -24 lines 0 comments Download
A + tools/telemetry/telemetry/web_components/web_component_bootstrap.js View 1 chunk +3 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/web_components/web_component_unittest.py View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nduca
ptal
6 years, 9 months ago (2014-03-27 02:00:33 UTC) #1
dtu
lgtm
6 years, 9 months ago (2014-03-27 20:04:31 UTC) #2
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 9 months ago (2014-03-27 20:09:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/214143002/1
6 years, 9 months ago (2014-03-27 20:12:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:47:59 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 23:47:59 UTC) #6
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 9 months ago (2014-03-28 00:38:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/214143002/1
6 years, 9 months ago (2014-03-28 00:39:12 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:49:34 UTC) #9
Message was sent while issue was closed.
Change committed as 260044

Powered by Google App Engine
This is Rietveld 408576698